chore: fix height issue

[jsartisan]

Fixes #40092

Summary by CodeRabbit

• Style
  • Improved the welcome banner’s layout by switching to a more flexible height setting.
  • Adjusted vertical alignment with additional top padding for users with elevated privileges, enhancing overall spacing and visual consistency.

[coderabbitai]

Walkthrough

The pull request modifies the styling of the UserWelcomeScreenTextBanner component. The fixed height property has been replaced with min-height, and the conditional CSS for vertical alignment now applies additional top padding (padding-block: var(--ads-spaces-12)) for super users rather than simply centering the content.

Changes

File Path	Change Summary
app/client/src/pages/setup/common.tsx	Updated UserWelcomeScreenTextBanner: replaced height with min-height and changed conditional styling to add top padding for super users.

Assessment against linked issues

Objective	Addressed	Explanation
Header text layout issue in plan selection page [#40092]	❌	No modifications have been made to the plan selection page header.

Suggested labels

skip-changelog

Poem

In our code, a banner found new flair,
With min-height and padding, it stands rare.
Super users gain a fresh aligned view,
A subtle change, both clean and true.
CodeRabbit inspires style anew!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b71196e and 076ca4a.

📒 Files selected for processing (1)

• app/client/src/pages/setup/common.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: client-lint / client-lint
• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-prettier / prettier-check
• GitHub Check: client-build / client-build

🔇 Additional comments (2)

app/client/src/pages/setup/common.tsx (2)

154-154: Good improvement from fixed height to min-height

Changing from fixed height to min-height: 100% allows the component to expand when content requires more space, preventing content truncation issues. This directly addresses the height issue mentioned in PR #40092.

---

160-160: Appropriate padding adjustment for non-super users

The addition of padding-block: var(--ads-spaces-12) provides consistent vertical spacing for non-super users while maintaining the center alignment. This change complements the min-height adjustment to ensure proper content display.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.