Skip to content

fix: Updating styles for invite modal to fix UI issue #40144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

fix: Updating styles for invite modal to fix UI issue #40144

merged 2 commits into from
Apr 7, 2025

Conversation

ankitakinger
Copy link
Contributor

@ankitakinger ankitakinger commented Apr 7, 2025 •
edited by github-actions bot
Loading

Description

Updating styles for invite modal to fix UI issue

Fixes #40142

Automation

/ok-to-test tags="@tag.Settings"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14314943197
Commit: a459f41
Cypress dashboard.
Tags: @tag.Settings
Spec:

Mon, 07 Apr 2025 17:19:46 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Style
    • Updated the alignment in the invite users form for a more balanced visual layout.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 7, 2025 •
edited
Loading

Walkthrough

The pull request modifies the StyledInviteFieldGroup within the Invite Users form by changing its align-items property from baseline to flex-start. This update adjusts the vertical alignment of the elements in the form to address UI misalignment issues, specifically those noted in the Add Users modal. No other functional changes or modifications to public entities were made.

Changes

File Change Summary
app/.../InviteUsersForm.tsx Updated StyledInviteFieldGroup: changed align-items from baseline to flex-start.

Assessment against linked issues

Objective Addressed Explanation
Fix alignment issues in Add Users modal [#40142] ✅

Poem

In the code's fine tapestry, a tweak takes its stance,
Centered components now find their elegant dance.
A small style shift, a bug bid adieu,
Alignments restored with a fresh, vibrant hue.
Debugs retreat as clean design enchants! 🚀

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 242933a and a459f41.

📒 Files selected for processing (1)
  • app/client/src/ce/pages/workspace/InviteUsersForm.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/client/src/ce/pages/workspace/InviteUsersForm.tsx
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-prettier / prettier-check
  • GitHub Check: client-build / client-build
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ankitakinger ankitakinger added the ok-to-test Required label for CI label Apr 7, 2025
@github-actions github-actions bot added Admin Settings Product Issues in admin settings pages Bug Something isn't working Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Platform Administration Pod Issues related to platform administration & management Production labels Apr 7, 2025
@ankitakinger
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/14314249471.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 40144.
recreate: .

@ankitakinger ankitakinger requested a review from jsartisan April 7, 2025 16:18
jsartisan
jsartisan previously approved these changes Apr 7, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025

Deploy-Preview-URL: https://ce-40144.dp.appsmith.com

@ankitakinger
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/14314965340.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 40144.
recreate: .

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025

Deploy-Preview-URL: https://ce-40144.dp.appsmith.com

@ankitakinger ankitakinger merged commit 5b2bdab into release Apr 7, 2025
45 checks passed
@ankitakinger ankitakinger deleted the fix/invite-modal branch April 7, 2025 17:31
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Apr 12, 2025
@ankitakinger
fix: Updating styles for invite modal to fix UI issue (appsmithorg#40144
f53310c 
)

## Description

Updating styles for invite modal to fix UI issue

Fixes [appsmithorg#40142](appsmithorg#40142)

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/14314943197>
> Commit: a459f41
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14314943197&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Settings`
> Spec:
> <hr>Mon, 07 Apr 2025 17:19:46 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Style**
- Updated the alignment in the invite users form for a more balanced
visual layout.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsartisan jsartisan jsartisan approved these changes

@albinAppsmith albinAppsmith Awaiting requested review from albinAppsmith

Assignees
No one assigned
Labels
Admin Settings Product Issues in admin settings pages Bug Something isn't working Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Platform Administration Pod Issues related to platform administration & management Production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Add Users modal is having alignment issues in the Users section of Admin settings
2 participants
@ankitakinger @jsartisan