Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: hardcoded sdk methods with console sdk #1722

Closed
wants to merge 20 commits into from
Closed

Conversation

ChiragAgg5k
Copy link
Member

What does this PR do?

Till now we were using a mixture of console sdk and hardcoded sdk methods in the repo. This lead to confusion and repetition of a lot of code.

This PR fixes this and adds any methods pending to be added to the console-sdk itself.

Test Plan

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes.

Copy link
Member

@ItzNotABug ItzNotABug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added Damodar for another set of review.

@ChiragAgg5k ChiragAgg5k marked this pull request as draft March 7, 2025 08:52
@ChiragAgg5k ChiragAgg5k closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants