chore: hide runtime specifications select for self-hosted. #1755
+66
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-03-18 18:14:32 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-03-18 18:14:33 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-03-18 18:14:31 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-03-18 18:14:32 CET |
ItzNotABug
reviewed
Mar 26, 2025
| required | ||
| disabled={specificationOptions.length < 1} | ||
| options={specificationOptions} | ||
| popover={isCloud && $organization?.billingPlan === BillingPlan.FREE |
There was a problem hiding this comment.
already isCloud here no?
Also lets move from doing a plan check to checking if the specification list only has one item [Free only has one]. @lohanidamodar makes sense?
| required | ||
| disabled={specificationOptions.length < 1} | ||
| options={specificationOptions} | ||
| popover={$organization?.billingPlan === BillingPlan.FREE |
There was a problem hiding this comment.
same as above on what we decide.
| placeholder="Select runtime specification" | ||
| bind:value={specification} | ||
| options={specificationOptions} | ||
| popover={$organization?.billingPlan === BillingPlan.FREE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hides runtime specifications selector for self-hosted.
Test Plan
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes.