Fix/fix relationship set and view #1877
Conversation
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-05-22 14:14:44 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-05-22 14:14:45 CET |
| @@ -110,7 +109,7 @@ | |||
| }); | |||
|
|
|||
| // Reactive statements | |||
| $: getCollections(search).then((res) => (collectionList = res)); | |||
| $: getCollections().then((res) => (collectionList = res)); | |||
There was a problem hiding this comment.
I don't remember as to why was this reactive.
There was a problem hiding this comment.
Probably because of the search, but with that being going its not needed anymore...
| return sdk | ||
| .forProject(page.params.region, page.params.project) | ||
| .databases.listCollections(databaseId, queries, search); | ||
| .databases.listCollections(databaseId, queries); |
There was a problem hiding this comment.
So search is being removed because the component is a basic dropdown rather than a combo box where you can type to search? This will make it difficult for people to find the option they need.
There was a problem hiding this comment.
This is getting the collections from the API. The combobox is filtering on the client based on what the API returned. ATM search is defaulting as null which results in 0 results coming from the API. So ATM it's entirely broken, and this fixes that.
Updating this to the ComboBox is still something we need to do, but there is a bug that the dropdown of the combobox falls behind the modal, so you cannot use it.
TLDR: this change is going from 100% broken to usable. We need to do more work to make it good.
What does this PR do?
Fix the pre select of the option in the relation overview of the document
Have you read the Contributing Guidelines on issues?
✅