add package.json to legacy files #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @bobzoller! I am going to close this as I don't think this makes sense as a feature due to the stuff discussed in #60. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
package.jsonto the list of legacy files, and uses jq to read the value ofengines.node. It'll be limited to asdf-friendly values which fits our use-case, although the docs say it could be specified as a range expression.I wasn't sure how psyched folks would be to add a dependency on jq, nor how complete we'd like to be about handling values of
engines.node, but at least this is a working proposal for closing #60.Feedback welcome!