Disable typing in py/private/pytest.py.tmpl

[Synss]

Disable type checking in generated code.

This fixes a regression that occurred after upgrading to the latest version of the rules. There, our tooling started producing the following typing errors.

bazel-out/k8-fastbuild/bin/packages/cmk-agent-based/__test__.py:35: error: Cannot find implementation or library stub for module named "coverage"  [import-not-found]
bazel-out/k8-fastbuild/bin/packages/cmk-agent-based/__test__.py:35: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
bazel-out/k8-fastbuild/bin/packages/cmk-agent-based/__test__.py:37: error: Argument 1 to "open" has incompatible type "str | None"; expected "int | str | bytes | PathLike[str] | PathLike[bytes]"  [arg-type]
bazel-out/k8-fastbuild/bin/packages/cmk-agent-based/__test__.py:78: error: Argument 1 to "int" has incompatible type "str | None"; expected "str | Buffer | SupportsInt | SupportsIndex | SupportsTrunc"  [arg-type]
bazel-out/k8-fastbuild/bin/packages/cmk-agent-based/__test__.py:84: error: Argument 1 to "Path" has incompatible type "str | None"; expected "str | PathLike[str]"  [arg-type]
bazel-out/k8-fastbuild/bin/packages/cmk-agent-based/__test__.py:109: error: Unsupported left operand type for + ("None")  [operator]
bazel-out/k8-fastbuild/bin/packages/cmk-agent-based/__test__.py:109: note: Left operand is of type "str | None"
bazel-out/k8-fastbuild/bin/packages/cmk-agent-based/__test__.py:114: error: Argument 1 to "open" has incompatible type "str | None"; expected "int | str | bytes | PathLike[str] | PathLike[bytes]"  [arg-type]
Found 6 errors in 1 file (checked 1 source file)

Related:

• Add types to file generated by __test__.py #428

---

Changes are visible to end-users: yes

This patch fixes a regression.

[CLAassistant]

All committers have signed the CLA.

[aspect-workflows]

Test

5 test targets passed

Targets

//examples/multi_version:py_version_default_test [k8-fastbuild]                 2s
//examples/multi_version:py_version_test [k8-fastbuild-ST-494921797612]         2s
//examples/pytest:pytest_test [k8-fastbuild]                                    2s
//examples/pytest:sharded/test [k8-fastbuild]                                   4s
//examples/virtual_deps:pytest_test [k8-fastbuild]                              2s

Total test execution time was 11s. 33 tests (86.8%) were fully cached saving 54s.

[arrdem]

Thanks for the contribution, my take is that #570 is a better approach since it allows us to provide more verification of the base code we're delivering and opens the door to removing the need for a template action in the normal cases.

[Synss]

Yes, indeed. In the long-term, it's certainly be better to type and lint the file instead of silencing the type checker.

I'd nevertheless propose the following, pragmatic approach:

• Merge this PR and make a patch release to let users upgrade more easily.
• Revert this PR when chore(py_pytest_main): Refactor to allow for linting #570 is ready and make a minor release.

[arrdem]

Not my favorite but I agree it's incrementally less broken. Let's take it for now.

[arrdem]

LGTM.