Skip to content

Add Cobalt Cloud machine Azure CI profile and runs. #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025

Conversation

LoopedBard3
Copy link
Contributor

@LoopedBard3 LoopedBard3 commented May 7, 2025

Add Cobalt Cloud machine Azure CI profile and runs. We have 3 added Linux Cobalt machines, so I decided to add them to each of the run types.

One thing that I am unsure about it that these machines are under a different virtual network as the cobalt machines were not available in the same data center as the other machines. I am not super familiar with the connection between the pipelines and the machines so please let me know if there is known work that will have to be done there.

Additional steps necessary to set this up:

  • Added cobaltcloud to the aspnetbenchmarks service bus (I am assuming service bus can be accessed across datacenters).
  • Added necessary environment variables to the cobalt-db-lin machine to act as the entry point for that network.
  • Setup the service bus cronjob and start the connection.
  • Did not need to add hosts file as the other VMs are pingable via their VM name.

@LoopedBard3 LoopedBard3 self-assigned this May 7, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a series of new CI configurations for Cobalt Cloud Linux machines across several pipeline groups.

  • Added Cobalt Cloud Linux job and profile configurations in the benchmark matrix file.
  • Updated job dependencies in the CI YAML file to include the new Cobalt Cloud Linux jobs.
  • Introduced new machine profiles in the Azure profile file.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
build/benchmarks.matrix.azure.yml Added new job groups for Cobalt Cloud Linux runs.
build/benchmarks-ci-azure.yml Added new Cobalt Cloud Linux jobs and updated dependencies.
build/azure.profile.yml Introduced new profiles for cobalt-cloud-lin and its relay variant.
Comments suppressed due to low confidence (1)

build/benchmarks-ci-azure.yml:107

  • [nitpick] The displayName numbering '2-' is reused for multiple jobs within the same grouping, which may cause confusion in the CI pipeline ordering. Consider updating the numbering to ensure unique and sequential identifiers for each job.
displayName: 2- Trends Cobalt Cloud Linux

@LoopedBard3 LoopedBard3 marked this pull request as draft May 7, 2025 23:28
@LoopedBard3
Copy link
Contributor Author

For now, I added a new service bus queue for the cobalt machines as they are in a different datacenter and VNet from the others. While this currently works with the current queue setup, it would probably be best long-term to update the benchmarks.template.liquid template. Not sure what the best approach would be, but I would be open to recommendations if we want them in this PR.

@LoopedBard3 LoopedBard3 marked this pull request as ready for review May 8, 2025 00:01
@LoopedBard3 LoopedBard3 merged commit 1bb3fe6 into aspnet:main May 8, 2025
2 checks passed
@LoopedBard3 LoopedBard3 deleted the AddCobaltMachinesToAzureCI branch May 8, 2025 18:51
LoopedBard3 added a commit to LoopedBard3/Benchmarks that referenced this pull request May 8, 2025
LoopedBard3 added a commit that referenced this pull request May 8, 2025
…2089)

This reverts commit 1bb3fe6. The Service bus for the cobalt machines is failing so this is causing the ci jobs to take much longer as they wait for each service bus request to timeout (10 min).
LoopedBard3 added a commit to LoopedBard3/Benchmarks that referenced this pull request May 8, 2025
LoopedBard3 added a commit that referenced this pull request May 9, 2025
…#2089) (#2090)

This reverts commit ed6ac8c. Previous service bus issues were fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants