-
Notifications
You must be signed in to change notification settings - Fork 243
Add Cobalt Cloud machine Azure CI profile and runs. #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cobalt Cloud machine Azure CI profile and runs. #2088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a series of new CI configurations for Cobalt Cloud Linux machines across several pipeline groups.
- Added Cobalt Cloud Linux job and profile configurations in the benchmark matrix file.
- Updated job dependencies in the CI YAML file to include the new Cobalt Cloud Linux jobs.
- Introduced new machine profiles in the Azure profile file.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
build/benchmarks.matrix.azure.yml | Added new job groups for Cobalt Cloud Linux runs. |
build/benchmarks-ci-azure.yml | Added new Cobalt Cloud Linux jobs and updated dependencies. |
build/azure.profile.yml | Introduced new profiles for cobalt-cloud-lin and its relay variant. |
Comments suppressed due to low confidence (1)
build/benchmarks-ci-azure.yml:107
- [nitpick] The displayName numbering '2-' is reused for multiple jobs within the same grouping, which may cause confusion in the CI pipeline ordering. Consider updating the numbering to ensure unique and sequential identifiers for each job.
displayName: 2- Trends Cobalt Cloud Linux
For now, I added a new service bus queue for the cobalt machines as they are in a different datacenter and VNet from the others. While this currently works with the current queue setup, it would probably be best long-term to update the benchmarks.template.liquid template. Not sure what the best approach would be, but I would be open to recommendations if we want them in this PR. |
)" This reverts commit 1bb3fe6.
…2088)" (aspnet#2089) This reverts commit ed6ac8c.
Add Cobalt Cloud machine Azure CI profile and runs. We have 3 added Linux Cobalt machines, so I decided to add them to each of the run types.
One thing that I am unsure about it that these machines are under a different virtual network as the cobalt machines were not available in the same data center as the other machines. I am not super familiar with the connection between the pipelines and the machines so please let me know if there is known work that will have to be done there.
Additional steps necessary to set this up: