Skip to content

Improve the parsing of values coming from headers #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2023

Conversation

stof
Copy link
Member

@stof stof commented Jun 30, 2023

  • integer values are casted instead of using FILTER_VALIDATE_INT, as done when reading from JSON or XML bodies
  • required fields are read without assigning null as fallback in the Result object (consistent with the behavior in JSON or XML bodies)

Relates to #1481

@stof
Copy link
Member Author

stof commented Jun 30, 2023

Unfortunately, the Route53 implementation in localstack is broken: localstack/localstack#5639 (comment)

@stof stof force-pushed the better_value_parsing branch from 0db3b2b to d6203c1 Compare July 1, 2023 15:32
@stof
Copy link
Member Author

stof commented Jul 1, 2023

OK, I removed the commit fixing the handling of required parameters coming from headers for now. I will re-submit it separately to be able to handle the case of the route53 integration tests separately.

@stof stof requested a review from jderusse July 1, 2023 15:34
@jderusse jderusse merged commit af7434a into async-aws:master Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants