-
-
Notifications
You must be signed in to change notification settings - Fork 136
Update generated code #1601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generated code #1601
Conversation
Tests are failing because the Sqs client has migrated to the JSON format instead of the XML format. For unit tests, it requires updating the tests to expect JSON format and the code generator also has a bug (which is why static analysis fails and is also triggered in some tests) |
Probably we should also bump the major version, since the exceptions have changed. |
AFAICT, we only have much more cases that have dedicated exceptions instead of the generic ClientException. As the specific exceptions extend ClientException, I'm not sure it is actually a BC break. |
} else { | ||
$payload['Attributes'] = []; | ||
foreach ($v as $name => $mv) { | ||
if (!QueueAttributeName::exists($mapKey)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$name
not $mapKey
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the bot will not automatically fix bugs in the code generator by reading review comments...
however, it might make sense to still make it a major version of that service in case some people use alternate implementations of SQS (in local setups for instance) which might not support the json format (which is basically what our own testsuite does) |
a9530bf
to
ca73124
Compare
For reference, the official AWS SDK released the switch to the JSON protocol in a patch release (3.285.2), not even in a minor release. |
ca73124
to
34a01f1
Compare
I guess we need to skip the localstack sqs tests for now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we should just re-gen the baseline file for those psalm issues.
For the integration tests, we could indeed skip them until #1596 is done and then localstack is used for the SQS integration tests instead of our custom unmaintained image (that does not support json). This will actually also need to wait for localstack to support the json protocol, which is in-progress |
34a01f1
to
c2e389e
Compare
I started the work of updating the testsuite for this. |
PR to add support to LocalStack has just been merged localstack/localstack#8268 a new version should be tagged soon |
9836cc9
to
8d8df4e
Compare
d8a4ca1
to
d530b57
Compare
d530b57
to
e69a55f
Compare
ok... I was wrong. SQS test suite used https://github.com/async-aws/testing-sqs (an not localstack) I've temporary disabled the tests to unlock this situation (this PR become bigger and bigger everyday) |
206f61f
to
76f8d14
Compare
d502276
to
7c9d121
Compare
I'm merging this so that the bot does not override the manual fixes tomorrow morning. |
The AWS API contract changed with version 3.288.1.
This PR contains the new definition for Services.