-
-
Notifications
You must be signed in to change notification settings - Fork 158
feat: add transition effect to mobile navbar #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I noticed a black border bottom line in the background, which I believe shouldn’t be there. Also, the spacing between the first nav item and the logo is too much.
@AceTheCreator I have fixed as per your suggestions, now have a look at that. |
Hey @rishvant i noticed that when we click on the venue button in the navbar, we are taken to the top of the page in the background. AsyncAPI-Conference.mp4 |
@ashmit-coder Its a bug and its present in deployed website as well, should I create a new issue for this or fix it in this only? AsyncAPIConference-GoogleChrome2025-03-2622-12-40-ezgif.com.mp4 |
you can fix it in this issue itself! |
@ashmit-coder @AceTheCreator I have fixed the issue, please check if its fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @rishvant
Could you maybe add some little changes?
- In the current venue dropdown, i will really appreciate if you can fix the location line break, which is happening basically due to container width
- No indication on the venue mobile nav that indicates it a dropdown
@AceTheCreator According to your suggestion, I have fixed those changes:
|
Description
Related issue(s)
#625