Skip to content

feat: add transition effect to mobile navbar #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

rishvant
Copy link
Contributor

Description

  • Improved mobile navbar with smooth transitions.
  • Adjusted z-index values to ensure proper layering and fix overlapping issues.
  • Enhanced overall user experience with better visibility and smoother animations.

Related issue(s)
#625

Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2bd77b0
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67f420f1f9256c00088e98a6
😎 Deploy Preview https://deploy-preview-655--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I noticed a black border bottom line in the background, which I believe shouldn’t be there. Also, the spacing between the first nav item and the logo is too much.

@rishvant
Copy link
Contributor Author

@AceTheCreator I have fixed as per your suggestions, now have a look at that.

@ashmit-coder
Copy link
Collaborator

Hey @rishvant i noticed that when we click on the venue button in the navbar, we are taken to the top of the page in the background.

AsyncAPI-Conference.mp4

@rishvant
Copy link
Contributor Author

rishvant commented Mar 26, 2025

@ashmit-coder Its a bug and its present in deployed website as well, should I create a new issue for this or fix it in this only?

AsyncAPIConference-GoogleChrome2025-03-2622-12-40-ezgif.com.mp4

@ashmit-coder
Copy link
Collaborator

@ashmit-coder Its a bug and its present in deployed website as well, should I create a new issue for this or fix it in this only?

AsyncAPIConference-GoogleChrome2025-03-2622-12-40-ezgif.com.mp4

you can fix it in this issue itself!

@rishvant
Copy link
Contributor Author

@ashmit-coder @AceTheCreator I have fixed the issue, please check if its fine

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rishvant

Could you maybe add some little changes?

  • In the current venue dropdown, i will really appreciate if you can fix the location line break, which is happening basically due to container width
  • No indication on the venue mobile nav that indicates it a dropdown

@rishvant
Copy link
Contributor Author

rishvant commented Apr 7, 2025

@AceTheCreator According to your suggestion, I have fixed those changes:

  • Added nowrap property to remove line break in venue dropdown
  • Added a dropdown icon in mobile nav after venue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants