-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: changed node and npm version in Development.md to a compatible version #1457
base: master
Are you sure you want to change the base?
docs: changed node and npm version in Development.md to a compatible version #1457
Conversation
…hat works correctly
|
WalkthroughThe pull request updates the troubleshooting section in the Changes
Possibly related issues
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -184,7 +184,7 @@ For the PR titles you can refer to [this guide](CONTRIBUTING.md?plain=1#L60) | |||
|
|||
If you encounter any issues during development or testing, please check the following: | |||
|
|||
1. Ensure you're using the correct Node.js version (18.12.0 or higher) and npm version (8.19.0 or higher). | |||
1. Ensure you're using the correct Node.js version (18.20.8 or higher) and npm version (10.8.2 or higher). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why 18.20.8
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the node version being used in the docker image in the repo so that way there will be consistency in the node version in local setup and in the docker container
|
Fixes: #1456
The minimum node and npm versions will be changed to the ones being used by docker, i.e., node:
18.20.8
and npm:10.8.2
which works as expected.Summary by CodeRabbit