-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove broken lint:tpl:validator script and its references #1490
base: master
Are you sure you want to change the base?
chore: remove broken lint:tpl:validator script and its references #1490
Conversation
|
WalkthroughThe changes remove a specific ESLint ignore directive from the Changes
Assessment against linked issues
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
🔇 Additional comments (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is unintended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has more changes than needed, specifically formatting the file, when it should just be deleting a line. I'm not sure if that will be accepted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I'd advise looking at changes made via VS Code's Git tab and committing file by file from the UI, instead of committing all files at once. This will make it easier to detect unintended changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I'd advise looking at changes made via VS Code's Git tab and committing file by file from the UI, instead of committing all files at once. This will make it easier to detect unintended changes.
well great advice but after i ran the lint it was still giving me great results without changing the harmony of the code and the repo
so no problem is coming yet.
still if the maintainers will advice me to change something in turbo.json
I'll do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has more changes than needed, specifically formatting the file, when it should just be deleting a line. I'm not sure if that will be accepted.
Let the maintainers decide that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another line that needs to be deleted: line 21 of the root package.json
.
No Need for that file it was by mistakenly added
|
There are no dead scripts, no references to templates-list-validator, and no unnecessary dependencies remained for the removed feature. |
This PR removes the unnecessary script npm run lint:tpl:validator and its references in many important files of the generator
Fixes: #1463
also i have verified it by running the lint.
Summary by CodeRabbit