[Temporary on v18.4.0 tag]: using tracing for theming debug #2673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving alignment of the debug within theming with the rest of atuin.
Originally, I had just added
log
as I was not sure how best to link in, but this usestracing
, which is present elsewhere.As such, you can see theming-related logging by using:
For example:
Unfortunately, it is a bit hard to read on top of an interactive prompt, so if there is a simple workaround I am missing, please say.
Originally, I was worried about theme debug interfering with other logging, but having a
debug
parameter may be redundant if tracing can give more control anyway - perhaps it should be removed?Checks