Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Temporary on v18.4.0 tag]: using tracing for theming debug #2673

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

philtweir
Copy link
Contributor

@philtweir philtweir commented Apr 6, 2025

Improving alignment of the debug within theming with the rest of atuin.

Originally, I had just added log as I was not sure how best to link in, but this uses tracing, which is present elsewhere.

As such, you can see theming-related logging by using:

ATUIN_LOG=1 atuin search -i

For example:

Screenshot From 2025-04-06 18-53-42

Unfortunately, it is a bit hard to read on top of an interactive prompt, so if there is a simple workaround I am missing, please say.

Originally, I was worried about theme debug interfering with other logging, but having a debug parameter may be redundant if tracing can give more control anyway - perhaps it should be removed?

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@ellie
Copy link
Member

ellie commented Apr 7, 2025

btw you can filter tracing by specifying the module, eg

ATUIN_LOG=atuin_client=debug

to set logs to debug, only for atuin_client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants