Skip to content

Prevent setting invalid MySQL TIMESTAMPs for assessment dates #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Prevent setting invalid MySQL TIMESTAMPs for assessment dates #2283

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a5b5a7
Fix viewing GitHub submissions
NicholasMy Feb 17, 2025
baaf379
Merge branch 'master' into master
KesterTan Mar 17, 2025
0a9c5ac
Merge branch 'autolab:master' into master
NicholasMy Mar 27, 2025
8930bbe
Validate assessment dates are compatible with MySQL TIMESTAMP type
NicholasMy Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions app/models/assessment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ class Assessment < ApplicationRecord
validates :name, format: { with: /\A[^0-9].*/, message: "can't have leading numeral" }
validates :display_name, length: { minimum: 1 }
validate :verify_dates_order
validate :verify_dates_valid_for_mysql
validate :handin_directory_and_filename_or_disable_handins, if: :active?
validate :handin_directory_exists_or_disable_handins, if: :active?
validate :valid_handout
Expand Down Expand Up @@ -676,6 +677,21 @@ def verify_dates_order
errors.add :end_at, "must be after the due date" if due_at > end_at
end

def verify_dates_valid_for_mysql
# MySQL TIMESTAMP range is 1970-01-01 00:00:01 to 2038-01-19 03:14:07
min_time = Time.at(1).utc # 1970-01-01 00:00:01 UTC
max_time = Time.at(2**31 - 1).utc # 2038-01-19 03:14:07 UTC
if start_at < min_time || start_at > max_time
errors.add :start_at, "must be between 1970-01-01 and 2038-01-19"
end
if due_at < min_time || due_at > max_time
errors.add :due_at, "must be between 1970-01-01 and 2038-01-19"
end
if end_at < min_time || end_at > max_time
errors.add :end_at, "must be between 1970-01-01 and 2038-01-19"
end
end

def handin_directory_and_filename_or_disable_handins
if disable_handins?
true
Expand Down
Loading