feat(auth): improve identity center login parameter handling #2059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip interactive prompts when identity provider URL and region are
provided via command line arguments. Always save parameters to database
for future use regardless of input method.
Current behavior:
```
q login --license pro --identity-provider https://<some-start-url>.awsapps.com/start --region us-east-2
✔ Enter Start URL · https://<some-start-url>.awsapps.com/start
✔ Enter Region · us-east-2
Device authorized
Logged in successfully
```
Behavior after changes:
```
% cargo run --bin cli -- login --license pro --identity-provider https://<some-start-url>.awsapps.com/start --region us-east-2
Compiling cli v1.10.1 (/amazon-q-developer-cli/crates/cli)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.77s
Running `target/debug/cli login --license pro --identity-provider 'https://<some-start-url>.awsapps.com/start' --region us-east-2`
Logged in
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Skip interactive prompts when identity provider URL and region are provided via command line arguments. Always save parameters to database for future use regardless of input method.
Current behavior:
Behavior after changes: