Skip to content

New CLI examples for API Gateway #9544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

daniil-millwood
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@elysahall elysahall self-requested a review June 11, 2025 00:03
@elysahall elysahall self-assigned this Jun 11, 2025
@elysahall elysahall added documentation This is a problem with documentation. pr:work-in-progress This PR is a draft and needs further work. labels Jun 11, 2025
Copy link
Collaborator

@elysahall elysahall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission. Please review the suggestions, commit your changes, and push them to your PR.

aws apigatewayv2 create-routing-rule \
--domain-name 'regional.example.com' \
--priority 50 \
--conditions '[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 8-24 need to be condensed to a single line or escaped.

@@ -0,0 +1,52 @@
**To create a routing rule**

The following ``create-routing-rule`` example creates a routing rule with a priority of 50. ::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following ``create-routing-rule`` example creates a routing rule with a priority of 50. ::
The following ``create-routing-rule`` example creates a routing rule with a priority of ``50``. ::

aws apigatewayv2 put-routing-rule \
--domain-name 'regional.example.com' \
--priority 150 \
--conditions '[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, lines 8-24 need to be condensed to a single lined or every line needs to be escaped.

@daniil-millwood
Copy link
Contributor Author

Hi Elysa, I address your feedback and made a new commit to avoid confusion. Thanks.

@AndrewAsseily AndrewAsseily added needs-review This issue or pull request needs review from a core team member. and removed pr:work-in-progress This PR is a draft and needs further work. labels Jun 18, 2025
@AndrewAsseily AndrewAsseily self-requested a review June 18, 2025 14:24
@AndrewAsseily AndrewAsseily self-assigned this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. needs-review This issue or pull request needs review from a core team member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants