Track feature IDs for retry modes, CBOR, and request compression #9555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdaily
approved these changes
Jun 18, 2025
| @@ -22,6 +22,25 @@ | |||
| from tests import ClientHTTPStubber | |||
|
|
|||
|
|
|||
| def get_captured_ua_strings(stubber): | |||
There was a problem hiding this comment.
Just confirming that this comes from boto/botocore#3443?
There was a problem hiding this comment.
Ah, yeah. I think that file had intentionally diverged between CLI and botocore, so grabbed just the bits I needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: CLI-5164, CLI-6502
Description of changes: Ports the following botocore PRs:
Deviations:
legacyretry mode, so skipped that feature ID.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.