Skip to content

Update DocModel.php #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update DocModel.php #3111

wants to merge 1 commit into from

Conversation

LDAV
Copy link

@LDAV LDAV commented Apr 29, 2025

${} for string interpolation inside double quotes in PHP is deprecated

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

${} for string interpolation inside double quotes in PHP is deprecated
@stobrien89
Copy link
Member

Hi @LDAV,

Thanks for the contribution. In this particular case, we're trying to access variables within the doc model that are prefixed with $, so we're not actually using it for interpolation (hence the escape char). I'd prefer to keep the existing code. Let us know if you have any questions.

@stobrien89 stobrien89 closed this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants