Update python-parser's cpython dependency #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 25, 2016 08:49
Signed-off-by: Tibor Benke <[email protected]>
1. py_fn! needs a Python token 2. py_class! is preferred way to wrap Rust types into Python objects * if we need to modify the wrapped object, we have to put it inside a RefCell * for the details, see the docs: http://dgrunwald.github.io/rust-cpython/doc/cpython/macro.py_class!.html Signed-off-by: Tibor Benke <[email protected]>
Signed-off-by: Tibor Benke <[email protected]> Signed-off-by: Noémi Ványi <[email protected]>
rustfmt searches recursively for this file, so we can use the same configuration file for all Rust modules. Signed-off-by: Tibor Benke <[email protected]>
Signed-off-by: Tibor Benke <[email protected]>
|
@kvch Could you review this PR? Thanks! :) |
Signed-off-by: Tibor Benke <[email protected]>
|
I bumped the version (I like to bump it every time in the last commit of a PR according to the rules of semantic versioning. Unfortunately, I tend to forget these bumps 😢 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used a forked version of rust-cpython (0.5) with some custom functions. rust-cpython (0.6) is still not released, but it contains several improvements compared to 0.5.
I have an open PR in the upstream rust-cpython repository: dgrunwald/rust-cpython#53
Once it is merged, we can update the master branch in my forked repository (https://github.com/ihrwein/rust-cpython) and use it for building this parser.
This PR does the following things:
This change is