Skip to content

Update Makefile #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Makefile #292

wants to merge 2 commits into from

Conversation

macfly-base
Copy link

Reduced Repetition:
Used {cache,lib,out} instead of multiple rm -rf lines. Shortened Git checkout process with git -C instead of cd inside checkout-op-commit and checkout-base-contracts-commit.

Better Readability & Maintainability:
Clearer comments.
Consistent indentation and grouping.

More Efficient Git Operations:
Uses git -C for running commands in specific directories without requiring cd.

Ensures fetch --depth=1 for performance

Reduced Repetition:
Used {cache,lib,out} instead of multiple rm -rf lines.
Shortened Git checkout process with git -C instead of cd inside checkout-op-commit and checkout-base-contracts-commit.

Better Readability & Maintainability:
Clearer comments.
Consistent indentation and grouping.

More Efficient Git Operations:
Uses git -C for running commands in specific directories without requiring cd.

Ensures fetch --depth=1 for performance
@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns wbnns added the base protocol review To be reviewed by the Base web team label Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base protocol review To be reviewed by the Base web team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants