U15 Mainnet Task #322
U15 Mainnet Task #322
Conversation
🟡 Heimdall Review Status
|
| @@ -0,0 +1,18 @@ | |||
| OP_COMMIT=c8b9f62736a7dad7e569719a84c406605f4472e6 | |||
There was a problem hiding this comment.
| @@ -0,0 +1,18 @@ | |||
| OP_COMMIT=c8b9f62736a7dad7e569719a84c406605f4472e6 | |||
| BASE_CONTRACTS_COMMIT=2d0adea2460e3419dbcd77ac48dd2efc9a9a375f | |||
| BASE_CONTRACTS_COMMIT=2d0adea2460e3419dbcd77ac48dd2efc9a9a375f | ||
|
|
||
| ABSOLUTE_PRESTATE=0x03682932cec7ce0a3874b19675a6bbc923054a7b321efc7d3835187b172494b6 | ||
|
|
There was a problem hiding this comment.
Obtained from: https://docs.optimism.io/notices/upgrade-15
| # COORDINATOR_SAFE_ADDR=0x646132a1667ca7ad00d36616afba1a28116c770a | ||
| # SAFE_A=0x5dfEB066334B67355A15dc9b67317fD2a2e1f77f | ||
| # SAFE_B=0x6af0674791925f767060dd52f7fb20984e8639d8 | ||
| # LEDGER_ACCOUNT=1 |
| sign-cb: | ||
| $(GOPATH)/bin/eip712sign --ledger --hd-paths "m/44'/60'/$(LEDGER_ACCOUNT)'/0/0" -- \ | ||
| forge script --rpc-url $(L1_RPC_URL) UpgradeDGF \ | ||
| --sig "sign(address,address)" $(OWNER_SAFE) $(CB_SIGNER_SAFE_ADDR) |
There was a problem hiding this comment.
Need to change signature to sign(address,address) instead of sign(address).
Where can i get the second safe address from?
| // TODO: Confirm expected version | ||
| string public constant EXPECTED_VERSION = "1.4.1"; |
| @@ -0,0 +1,12 @@ | |||
| OP_COMMIT=ef7a933ca7f3d27ac40406f87fea25e0c3ba2016 | |||
There was a problem hiding this comment.
It does not match the commit we used on Sepolia, is it intentional?
There was a problem hiding this comment.
This corresponds to op-contracts/v3.0.0-rc.2. Should be good https://github.com/ethereum-optimism/optimism/commits/op-contracts/v3.0.0-rc.2/
| clockExtension: clockExtension, | ||
| maxClockDuration: maxClockDuration, | ||
| vm: bigStepper, | ||
| weth: currentFdg.weth(), |
There was a problem hiding this comment.
We could extract it as for the other params.
There was a problem hiding this comment.
I think it's fine to leave it this way - the weth implementations are not the same between FaultDisputeGame and PermissionedDisputeGame
| address public pdgImpl; | ||
|
|
||
| constructor() { | ||
| OWNER_SAFE = vm.envAddress("OWNER_SAFE"); |
There was a problem hiding this comment.
We could also extract the SYSTEM_CONFIG so that we know all env vars are read in the constructor.
| // _postcheckHasAnchorState(CANNON); | ||
| // _postcheckHasAnchorState(PERMISSIONED_CANNON); |
There was a problem hiding this comment.
Seems like this should be uncommented.
| using LibDuration for Duration; | ||
| using LibGameType for GameType; | ||
|
|
||
| // TODO: Confirm expected version |
There was a problem hiding this comment.
Could probably remove this comment
| // TODO: Confirm expected version | ||
| string public constant EXPECTED_VERSION = "1.4.1"; | ||
|
|
||
| SystemConfig internal _SYSTEM_CONFIG = SystemConfig(vm.envAddress("SYSTEM_CONFIG")); |
There was a problem hiding this comment.
We could assign this as a local variable in the setUp function
| clockExtension: clockExtension, | ||
| maxClockDuration: maxClockDuration, | ||
| vm: bigStepper, | ||
| weth: currentFdg.weth(), |
There was a problem hiding this comment.
I think it's fine to leave it this way - the weth implementations are not the same between FaultDisputeGame and PermissionedDisputeGame
| approve-op: | ||
| forge script --rpc-url $(L1_RPC_URL) UpgradeDGF \ | ||
| --sig "approve(address[],bytes)" [$(OP_SIGNER_SAFE_ADDR)] $(SIGNATURES) \ | ||
| --ledger --hd-paths "m/44'/60'/$(LEDGER_ACCOUNT)'/0/0" --broadcast |
There was a problem hiding this comment.
| --ledger --hd-paths "m/44'/60'/$(LEDGER_ACCOUNT)'/0/0" --broadcast | |
| --ledger --hd-paths "m/44'/60'/$(LEDGER_ACCOUNT)'/0/0" --broadcast -vvvv |
Mainnet smart contract update tasks for Isthmus: https://docs.optimism.io/notices/upgrade-15