Skip to content

Fix/sidebar foundry links #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wamimi
Copy link
Contributor

@wamimi wamimi commented May 8, 2025

What changed? Why?

  • Fixed broken links in the sidebar of the BaseDocs website (docs.base.org).
  • In the sidebar, under the Learn section, there is a Development With Foundry subsection.
  • The links for "Introduction to Foundry" and "Testing Smart Contracts" were previously pointing to:
    • https://docs.base.org/tutorials/intro-to-foundry-setup
    • https://docs.base.org/tutorials/intro-to-foundry-testing
  • These links were broken and resulted in "Page Not Found" errors.
  • Updated the sidebar configuration so these links now point to the correct slugs:
    • /intro-to-foundry-setup
    • /intro-to-foundry-testing
  • This ensures users can access the correct Foundry tutorial documentation from the sidebar.

Notes to reviewers

  • The change is limited to the sidebar configuration for the BaseDocs site.
  • No other files or features were modified.
  • Please verify that the sidebar navigation under Learn > Development With Foundry now correctly routes to the intended documentation pages.

How has it been tested?

  • Manual review of the sidebar.ts file to ensure only the intended links were updated.

Have you tested the following pages?

BaseWeb

  • base.org
  • base.org/names
  • base.org/builders
  • base.org/ecosystem
  • base.org/name/jesse
  • base.org/manage-names
  • base.org/resources

BaseDocs

  • docs.base.org (sidebar links reviewed)
  • docs sub-pages

Copy link

vercel bot commented May 8, 2025

@wamimi is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented May 8, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 -1/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

},
{
text: 'Testing Smart Contracts ↗',
link: 'https://docs.base.org/tutorials/intro-to-foundry-testing',
link: '/intro-to-foundry-testing',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links aren't valid, to test, they should work when you prepend https://docs.base.org/

e.g.

https://docs.base.org/intro-to-foundry-testing (doesn't work)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback! I’ll follow up with a fix and update the PR accordingly

Copy link
Contributor

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wamimi

Thanks! Left a note in-line WRT a link issue

@wbnns wbnns added change(s) requested One or more changes have been requested base docs review To be reviewed by the Base docs team labels May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base docs review To be reviewed by the Base docs team change(s) requested One or more changes have been requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants