-
Notifications
You must be signed in to change notification settings - Fork 841
Fix/sidebar foundry links #2327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@wamimi is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
🟡 Heimdall Review Status
|
}, | ||
{ | ||
text: 'Testing Smart Contracts ↗', | ||
link: 'https://docs.base.org/tutorials/intro-to-foundry-testing', | ||
link: '/intro-to-foundry-testing', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These links aren't valid, to test, they should work when you prepend https://docs.base.org/
e.g.
https://docs.base.org/intro-to-foundry-testing (doesn't work)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback! I’ll follow up with a fix and update the PR accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left a note in-line WRT a link issue
What changed? Why?
https://docs.base.org/tutorials/intro-to-foundry-setup
https://docs.base.org/tutorials/intro-to-foundry-testing
/intro-to-foundry-setup
/intro-to-foundry-testing
Notes to reviewers
How has it been tested?
Have you tested the following pages?
BaseWeb
BaseDocs