-
-
Notifications
You must be signed in to change notification settings - Fork 586
refactor/docs: improve compile_pip_requirements error message and docs #2792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to improve the error messaging!
Just a quick partial review.
934768c
to
3caa444
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no blockers on my end. I'll let @rickeylev decide when to add to the merge queue.
Thanks!
else: | ||
raise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nit: the sys.exit
will mean you don't reach L239 so you don't actually need the else
except ...:
if ...:
sys.exit(1)
raise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure; I like being explicit 🙂
LGTM FYI: Avoid force-pushing during PR review. What happens is comments get "lost" -- one can see them on the "conversation" pane, but can't actually access them in the "review" pane. It also clobbers the history of changes, which makes it harder to see what was changed in between review. |
@rickeylev Not sure what the build failure is, pretty sure it's ephemeral? |
Yeah, looks like a temporary network error. I updated this head, so CI is running again and it's back in the merge queue. |
Resolution failure is the most common error from pip-compile, so we should make sure the error message is as clean as it can be. Previously, the output was cluttered with the exception traceback, which makes the actual error hard to see (several nested traceback).
The new output shortens it with a nicer message:
Fixes #2763