Fixing release workflow #1736
Merged
Fixing release workflow #1736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release attempt failed https://github.com/bazel-contrib/rules_scala/actions/runs/14926599712 release_prep_command was removed in bazel-contrib/.github#32 workspace_snippet.sh was renabed to release_prep.sh this is a hardcoded path that release workflow expects
alexeagle
approved these changes
May 9, 2025
|
@mbland no worries, I missed that too. I'm grateful for all the work you did! |
mbland
added a commit
to mbland/rules_scala
that referenced
this pull request
May 17, 2025
Explicitly loads all symbols affected by `--incompatible_disable_autoloads_in_main_repo` to fix `last_green` Bazel builds. Adds `rules_shell` as a dev dependency and updates files to fix `test_bzlmod_macros.sh` and `test_dependency_versions.sh`. As a result of using Buildifier to add the missing `load` statements, Buildifier reordered the `load` statements as well. Fixes the following breakage when using the `last_green` build from bazelbuild/bazel@f08d561 (and other breakages blocked by this one): ```sh $ bazel run //tools:lint_check ERROR: scala/private/rules/scala_test.bzl:130:21: name 'JavaInfo' is not defined ERROR: .../external/+dev_deps+com_github_bazelbuild_buildtools/buildifier/BUILD.bazel:3:10: While resolving toolchains for target @@+dev_deps+com_github_bazelbuild_buildtools//buildifier:buildifier (b5bbebe): invalid registered toolchain '//test/proto:scalapb_toolchain': error loading package 'test/proto': at /Users/mbland/src/bazel-contrib/rules_scala/scala/scala.bzl:35:5: compilation of module 'scala/private/rules/scala_test.bzl' failed ERROR: Analysis of target '//tools:lint_check' failed; build aborted: Analysis failed ``` Fixed using Buildifier 8.2.0 by first running the following to get the list of appropriate warnings: ```txt buildifier --lint=warn -r . 2>&1 | grep -- native- | awk '{print $2}' | sort | uniq ``` then running: ```txt buildifier --lint=fix \ --warnings=native-java-common,native-java-info,native-sh-test,native-sh-binary \ -r . ``` I also ran it separately on the changed files in `deps/test` and `scala/private/macros/test`, since Buildifier didn't automatically find them. --- bazelbuild/bazel@d87eaf5 from 2025-05-08 at 8:03am EDT flipped `--incompatible_disable_autoloads_in_main_repo` to `true` to prepare for Bazel 9. I did confirm that setting `--noincompatible_disable_autoloads_in_main_repo` resolved the breakage before using Buildifier to add the necessary `load` statements. Pull request bazel-contrib#1735 was the last to pass the `last_green` CI build using bazelbuild/bazel@94e0b44 from 2025-05-08 at 7:39am EDT. This was two commits before the commit that flipped `--incompatible_disable_autoloads_in_main_repo`: - https://buildkite.com/bazel/rules-scala-scala/builds/5596#0196afc2-4af3-4202-8232-d5f5fe113349 Pull request bazel-contrib#1736 failed the `last_green` CI build using bazelbuild/bazel@cac54c4 from 2025-05-09 at 6:14am EDT. That job ran on 2025-05-09 at 6:47am EDT. The `last_green` configuration in `.bazelci/presubmit.yml` emits a warning if the build fails. This warning was present on the build page, but we've overlooked it until now: - https://buildkite.com/bazel/rules-scala-scala/builds/5598#0196b4a8-e593-431a-ab4c-8d8471d9b08b Part of this change copies more files from `test/jmh` into the `test_dependency_versions.sh` test directory. It also replicates targets from `//test/jmh` in `deps/test/BUILD.bazel.test` to replace the previous dependency on `@rules_scala//test/jmh:add_numbers`. This is because `//test/jmh` now has a `load` dependency on `@rules_shell`, which is a `dev_dependency` of `@rules_scala`. Since `@rules_shell` isn't visible to `@rules_scala` when it isn't the root module, this broke the build within `test_dependency_versions.sh`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Release attempt failed https://github.com/bazel-contrib/rules_scala/actions/runs/14926599712
release_prep_command was removed in bazel-contrib/.github#32
workspace_snippet.sh was renabed to release_prep.sh this is a hardcoded path that release workflow expects