-
Notifications
You must be signed in to change notification settings - Fork 409
add support for importing typescript types and deduping imports #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
srsudar
wants to merge
25
commits into
bcherny:master
Choose a base branch
from
srsudar:sam-exports
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
bc95fd2
wip of tests
srsudar e8bfbec
god what a faff
srsudar 4b6c542
can run with this:
srsudar b208580
wip
srsudar 1b1c108
works, kindof?
srsudar 6d91bfd
slowly, slowly
srsudar 4797cfe
wip
srsudar e77b219
works with types
srsudar 47c4c68
change title
srsudar e88ad99
rm logs
srsudar faed364
undo a couple things
srsudar bbf3626
rm the thing
srsudar 62c0848
fix a line maybe
srsudar d1be289
works with node dist/src/cli.js --useTypeImports --declareExternallyR…
srsudar abbdbb7
rm logs and debuggers
srsudar e861502
progress! three tests broken
srsudar e8f5d70
fix thing
srsudar 9b17ecb
fix the thing maybe
srsudar 92e05fa
add a test
srsudar 9b37b73
undo some changes
srsudar 2bc6a18
cleanup
srsudar beca685
clean up options a bit
srsudar 26d4584
revert another thing
srsudar db3f510
update test and snapshot
srsudar adac127
rm $refPath thing
srsudar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems less than ideal. I need this elsewhere, and I'm wondering if there's a more natural way to register the source path for this schema without needing to keep all references in this map.