Re-add ruby switch #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partial revert of dbd0f6c
| @@ -10,19 +10,16 @@ | |||
| notifies :run, "execute[apt-get update]", :immediately | |||
| end | |||
|
|
|||
| packages = ["build-essential", "ruby#{node['brightbox-ruby']['version']}"] | |||
| packages = ["build-essential", "ruby#{node['brightbox-ruby']['version']}", "ruby-switch"] | |||
|
Is your claim that this test fails without this commit? |
|
Yes, it does. With a massive caveat that I forgot to mention... $ ruby -v
ruby 1.9.3p484 (2013-11-22 revision 43786) [x86_64-linux]
$ ruby2.1 -v
ruby 2.1.6p336 (2015-04-13 revision 50298) [x86_64-linux-gnu] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial revert of dbd0f6c
Without ruby switch then after installing
$ rubyremains unchanged (and I have to use$ ruby2.1). You could just change the default but now it is in the Brightbox PPA I can't see why you wouldn't want to install it.