Skip to content

Commit 249456c

Browse files
committed
.ok_or() -> .ok_or_else()
1 parent a7354d8 commit 249456c

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

crates/bevy_reflect/src/serde/de.rs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -548,12 +548,9 @@ impl<'a, 'de> Visitor<'de> for TypeIdVisitor<'a> {
548548
where
549549
E: de::Error,
550550
{
551-
let reg = self
552-
.registry
553-
.get_with_name(v)
554-
.ok_or(serde::de::Error::custom(
555-
"attempt to deserialize type name not present in registry",
556-
))?;
551+
let reg = self.registry.get_with_name(v).ok_or_else(|| {
552+
serde::de::Error::custom("attempt to deserialize type name not present in registry")
553+
})?;
557554
Ok(reg.type_id())
558555
}
559556
}

crates/bevy_reflect/src/serde/ser.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,9 @@ impl<'a> Serialize for TypeIdSerializer<'a> {
134134
let ty_name = self
135135
.registry
136136
.get(*self.value)
137-
.ok_or(serde::ser::Error::custom(
138-
"attempt to serialize TypeId not found in TypeRegistry",
139-
))?
137+
.ok_or_else(|| {
138+
serde::ser::Error::custom("attempt to serialize TypeId not found in TypeRegistry")
139+
})?
140140
.name();
141141

142142
let mut state = serializer.serialize_map(Some(2))?;

0 commit comments

Comments
 (0)