check-dock and ci

Author: TotalKrill

crates/bevy_text/src/font.rs

@@ -1,7 +1,7 @@
 use bevy_asset::Asset;
 use bevy_reflect::{TypePath, TypeUuid};
 
-/// An [`Asset`](bevy_asset::Asset) that contains the data for a loaded font, if loaded as an asset.
+/// An [`Asset`] that contains the data for a loaded font, if loaded as an asset.
 ///
 /// Loaded by [`FontLoader`](crate::FontLoader).
 #[derive(Debug, TypeUuid, TypePath, Clone, Asset)]

crates/bevy_text/src/font_atlas_set.rs

@@ -47,10 +47,10 @@ type FontSizeKey = u32;
 
 /// Provides the interface for adding and retrieving rasterized glyphs, and manages the [`FontAtlas`]es.
 ///
-/// A `FontAtlasSet` is an [`Asset`](bevy_asset::Asset).
+/// A `FontAtlasSet` is an [`Asset`].
 ///
 /// There is one `FontAtlasSet` for each font:
-/// - When a [`Font`](crate::Font) is loaded as an asset and then used in [`Text`](crate::Text),
+/// - When a [`Font`] is loaded as an asset and then used in [`Text`](crate::Text),
 ///   a `FontAtlasSet` asset is created from a weak handle to the `Font`.
 /// - When a font is loaded as a system font, and then used in [`Text`](crate::Text),
 ///   a `FontAtlasSet` asset is created and stored with a strong handle to the `FontAtlasSet`.
@@ -172,6 +172,10 @@ impl FontAtlasSet {
     pub fn len(&self) -> usize {
         self.font_atlases.len()
     }
+    /// Returns the number of font atlases in this set
+    pub fn is_empty(&self) -> bool {
+        self.font_atlases.len() == 0
+    }
 
     /// Get the texture of the glyph as a rendered image, and its offset
     pub fn get_outlined_glyph_texture(

crates/bevy_text/src/font_loader.rs

@@ -27,7 +27,7 @@ impl AssetLoader for FontLoader {
         Box::pin(async move {
             let mut bytes = Vec::new();
             reader.read_to_end(&mut bytes).await?;
-            let font = Font::from_bytes(bytes.into());
+            let font = Font::from_bytes(bytes);
             // load_context.set_default_asset(LoadedAsset::new(font));
             Ok(font)
         })

crates/bevy_text/src/lib.rs

@@ -8,13 +8,13 @@
 //! A font *face* is part of a font family,
 //! and is distinguished by its style (e.g. italic), its weight (e.g. bold) and its stretch (e.g. condensed).
 //!
-//! In Bevy, [`Font`]s are loaded by the [`FontLoader`](FontLoader) as assets,
+//! In Bevy, [`Font`]s are loaded by the [`FontLoader`] as assets,
 //!
 //! # `TextPipeline`
 //!
 //! The [`TextPipeline`] resource does all of the heavy lifting for rendering text.
 //!
-//! [`Text`](Text) is first measured by creating a [`TextMeasureInfo`] in [`TextPipeline::create_text_measure`],
+//! [`Text`] is first measured by creating a [`TextMeasureInfo`] in [`TextPipeline::create_text_measure`],
 //! which is called by a system.
 //!
 //! Note that text measurement is only relevant in a UI context.
@@ -23,7 +23,7 @@
 //!
 //! 1. creates a [`Buffer`](cosmic_text::Buffer) from the [`TextSection`]s, generating new [`FontAtlasSet`]s if necessary.
 //! 2. iterates over each glyph in the [`Buffer`](cosmic_text::Buffer) to create a [`PositionedGlyph`],
-//!    retrieving glyphs from the cache, or rasterizing to a [`FontAtlas`](FontAtlas) if necessary.
+//!    retrieving glyphs from the cache, or rasterizing to a [`FontAtlas`] if necessary.
 //! 3. [`PositionedGlyph`]s are stored in a [`TextLayoutInfo`],
 //! which contains all the information that downstream systems need for rendering.
 

crates/bevy_text/src/pipeline.rs

@@ -53,7 +53,7 @@ impl Default for SwashCache {
 /// See the [crate-level documentation](crate) for more information.
 #[derive(Default, Resource)]
 pub struct TextPipeline {
-    /// Identifies a font [`ID`](cosmic_text::fontdb::ID) by its [`Font`] [`Asset`](bevy_asset::Asset) [`HandleId`].
+    /// Identifies a font [`ID`](cosmic_text::fontdb::ID) by its [`Font`] [`Asset`](bevy_asset::Asset).
     map_handle_to_font_id: HashMap<AssetId<Font>, cosmic_text::fontdb::ID>,
     /// The font system is used to retrieve fonts and their information, including glyph outlines.
     ///
@@ -87,7 +87,7 @@ impl TextPipeline {
         let (font_size, line_height) = (font_size as f32, line_height as f32);
         let metrics = Metrics::new(font_size, line_height);
 
-        let mut font_system = &mut acquire_font_system(&mut self.font_system)?;
+        let font_system = &mut acquire_font_system(&mut self.font_system)?;
 
         let spans: Vec<(&str, Attrs)> = sections
             .iter()
@@ -96,9 +96,9 @@ impl TextPipeline {
                 (
                     &section.value[..],
                     get_attrs(
-                        &section,
+                        section,
                         section_index,
-                        &mut font_system,
+                        font_system,
                         &mut self.map_handle_to_font_id,
                         fonts,
                     ),
@@ -348,7 +348,7 @@ fn get_attrs<'a>(
                 .db_mut()
                 .load_font_source(cosmic_text::fontdb::Source::Binary(data));
             // TODO: it is assumed this is the right font face
-            ids.last().unwrap().clone()
+            *ids.last().unwrap()
 
             // TODO: below may be required if we need to offset by the baseline (TBC)
             // see https://github.com/pop-os/cosmic-text/issues/123