Skip to content

Commit 64a8485

Browse files
committed
Disabling default features support in bevy_ecs, bevy_reflect and bevy (#5993)
# Objective - Fix disabling features in bevy_ecs (broken by #5630) - Add tests in CI for bevy_ecs, bevy_reflect and bevy as those crates could be use standalone
1 parent e4af823 commit 64a8485

File tree

3 files changed

+22
-1
lines changed

3 files changed

+22
-1
lines changed

.github/bors.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ status = [
1414
"check-compiles",
1515
"build-and-install-on-iOS",
1616
"run-examples-on-windows-dx12",
17+
"build-without-default-features (bevy)",
18+
"build-without-default-features (bevy_ecs)",
19+
"build-without-default-features (bevy_reflect)",
1720
]
1821

1922
use_squash_merge = true

.github/workflows/validation-jobs.yml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,3 +154,22 @@ jobs:
154154
with:
155155
name: screenshots
156156
path: .github/start-wasm-example/screenshot-*.png
157+
158+
build-without-default-features:
159+
strategy:
160+
matrix:
161+
crate: [bevy_ecs, bevy_reflect, bevy]
162+
runs-on: ubuntu-latest
163+
steps:
164+
- uses: actions/checkout@v3
165+
- uses: actions-rs/toolchain@v1
166+
with:
167+
toolchain: stable
168+
override: true
169+
- name: Install alsa and udev
170+
run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev
171+
- name: Build
172+
run: cargo build -p ${{ matrix.crate }} --no-default-features
173+
env:
174+
CARGO_INCREMENTAL: 0
175+
RUSTFLAGS: "-C debuginfo=0 -D warnings"

crates/bevy_ecs/src/change_detection.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
//! Types that detect when their internal data mutate.
22
33
use crate::{component::ComponentTicks, ptr::PtrMut, system::Resource};
4-
#[cfg(feature = "bevy_reflect")]
54
use std::ops::{Deref, DerefMut};
65

76
/// The (arbitrarily chosen) minimum number of world tick increments between `check_tick` scans.

0 commit comments

Comments
 (0)