Skip to content

Commit de2b1a4

Browse files
committed
bevy_reflect: Reflected char (#4790)
# Objective `char` isn't reflected. ## Solution Reflected `char`. --- ## Changelog * Reflected `char` ## Migration Guide > List too long to display
1 parent a0a14aa commit de2b1a4

File tree

1 file changed

+11
-0
lines changed
  • crates/bevy_reflect/src/impls

1 file changed

+11
-0
lines changed

crates/bevy_reflect/src/impls/std.rs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ use std::{
1616
};
1717

1818
impl_reflect_value!(bool(Hash, PartialEq, Serialize, Deserialize));
19+
impl_reflect_value!(char(Hash, PartialEq, Serialize, Deserialize));
1920
impl_reflect_value!(u8(Hash, PartialEq, Serialize, Deserialize));
2021
impl_reflect_value!(u16(Hash, PartialEq, Serialize, Deserialize));
2122
impl_reflect_value!(u32(Hash, PartialEq, Serialize, Deserialize));
@@ -37,6 +38,7 @@ impl_reflect_value!(Range<T: Serialize + Clone + for<'de> Deserialize<'de> + Sen
3738
impl_reflect_value!(Duration(Hash, PartialEq, Serialize, Deserialize));
3839

3940
impl_from_reflect_value!(bool);
41+
impl_from_reflect_value!(char);
4042
impl_from_reflect_value!(u8);
4143
impl_from_reflect_value!(u16);
4244
impl_from_reflect_value!(u32);
@@ -552,6 +554,15 @@ mod tests {
552554
assert!(std::time::Duration::ZERO.serializable().is_some());
553555
}
554556

557+
#[test]
558+
fn should_partial_eq_char() {
559+
let a: &dyn Reflect = &'x';
560+
let b: &dyn Reflect = &'x';
561+
let c: &dyn Reflect = &'o';
562+
assert!(a.reflect_partial_eq(b).unwrap_or_default());
563+
assert!(!a.reflect_partial_eq(c).unwrap_or_default());
564+
}
565+
555566
#[test]
556567
fn should_partial_eq_i32() {
557568
let a: &dyn Reflect = &123_i32;

0 commit comments

Comments
 (0)