Skip to content

Commit edb34cd

Browse files
authored
Run example validation jobs on ubuntu-latest (#17169)
# Objective Fixes #17164 ## Solution - Switch to `ubuntu-latest` - Remove `libegl1-mesa`. It seems that whatever this was providing is now covered by other deps or their deps? ## Testing Tested [over here](rparrett#21) by commenting out workflow `if` condition.
1 parent 8f32c79 commit edb34cd

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/start-wasm-example/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
"author": "",
99
"license": "ISC",
1010
"devDependencies": {
11-
"@playwright/test": "^1.28.1"
11+
"@playwright/test": "^1.49.1"
1212
},
1313
"dependencies": {
1414
"dotenv": "^16.0.1"
1515
}
16-
}
16+
}

.github/workflows/validation-jobs.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ jobs:
8080
run-examples-linux-vulkan:
8181
# also run when pushed to main to update reference screenshots
8282
if: ${{ github.event_name != 'pull_request' }}
83-
runs-on: ubuntu-22.04
83+
runs-on: ubuntu-latest
8484
timeout-minutes: 30
8585
steps:
8686
- uses: actions/checkout@v4
@@ -90,7 +90,7 @@ jobs:
9090
- name: Install additional Linux dependencies for Vulkan
9191
run: |
9292
sudo add-apt-repository ppa:kisak/turtle -y
93-
sudo apt-get install --no-install-recommends libxkbcommon-x11-0 xvfb libegl1-mesa libgl1-mesa-dri libxcb-xfixes0-dev mesa-vulkan-drivers
93+
sudo apt-get install --no-install-recommends libxkbcommon-x11-0 xvfb libgl1-mesa-dri libxcb-xfixes0-dev mesa-vulkan-drivers
9494
- uses: actions/cache@v4
9595
with:
9696
path: |
@@ -185,7 +185,7 @@ jobs:
185185

186186
run-examples-on-wasm:
187187
if: ${{ github.event_name == 'merge_group' }}
188-
runs-on: ubuntu-22.04
188+
runs-on: ubuntu-latest
189189
timeout-minutes: 60
190190
steps:
191191
- uses: actions/checkout@v4
@@ -210,7 +210,7 @@ jobs:
210210
sudo apt-get update -y -qq
211211
sudo add-apt-repository ppa:kisak/turtle -y
212212
sudo apt-get update
213-
sudo apt install -y xvfb libegl1-mesa libgl1-mesa-dri libxcb-xfixes0-dev mesa-vulkan-drivers
213+
sudo apt install -y xvfb libgl1-mesa-dri libxcb-xfixes0-dev mesa-vulkan-drivers
214214
215215
- name: Install wasm-bindgen
216216
run: cargo install --force wasm-bindgen-cli

0 commit comments

Comments
 (0)