Skip to content

Clarify where the origin of the Cone primitive should lie #10616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alice-i-cecile opened this issue Nov 17, 2023 · 0 comments · Fixed by #13568
Closed

Clarify where the origin of the Cone primitive should lie #10616

alice-i-cecile opened this issue Nov 17, 2023 · 0 comments · Fixed by #13568
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Docs An addition or correction to our documentation

Comments

@alice-i-cecile
Copy link
Member 

          As @NiseVoid suggested (https://github.com/bevyengine/bevy/pull/10580#discussion_r1396055493), maybe we should mention where the origin of the cone should be so that different integrations have consistent representations?

If the options are the base and apex (tip), the base is more intuitive for me personally. I view cones like Wikipedia's description:

a three-dimensional geometric shape that tapers smoothly from a flat base (frequently, though not necessarily, circular) to a point called the apex or vertex.

Originally posted by @Jondolf in #10580 (comment)
@Kanabenki Kanabenki added C-Docs An addition or correction to our documentation A-Math Fundamental domain-agnostic mathematical operations labels Nov 18, 2023
@lynn-lumen lynn-lumen mentioned this issue May 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 29, 2024
@lynn-lumen
Clarify cone position (#13568)
4e72bf4 
# Objective

- Fixes #10616

## Solution

- Added docs describing the center as being the midpoint between the tip
and the center of its base.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify cone position lynn-lumen/bevy
2 participants
@alice-i-cecile @Kanabenki