Replace collision code in breakout example with code based Aabb2d::intersects
#11479
Labels
A-Physics
Collisions, kinematics, forces and more
C-Examples
An addition or correction to our examples
C-Feature
A new feature, making something new possible
Comments
rparrett
added
C-Feature
|
Pinging @Jondolf for an opinion / maybe some guidance for someone wanting to do this. |
alice-i-cecile
added
D-Trivial
|
IMO we should definitely remove the |
|
Yes, I agree we should remove the AABB and collision stuff from
|
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 29, 2024
# Objective Fixes #11479 ## Solution - Remove `collide_aabb.rs` - Re-implement the example-specific collision code in the example, taking advantage of the new `IntersectsVolume` trait. ## Changelog - Removed `sprite::collide_aabb::collide` and `sprite::collide_aabb::Collision`. ## Migration Guide `sprite::collide_aabb::collide` and `sprite::collide_aabb::Collision` were removed. ```rust // Before let collision = bevy::sprite::collide_aabb::collide(a_pos, a_size, b_pos, b_size); if collision.is_some() { // ... } // After let collision = Aabb2d::new(a_pos.truncate(), a_size / 2.) .intersects(&Aabb2d::new(b_pos.truncate(), b_size / 2.)); if collision { // ... } ``` If you were making use `collide_aabb::Collision`, see the new `collide_with_side` function in the [`breakout` example](https://bevyengine.org/examples/Games/breakout/). ## Discussion As discussed in the linked issue, maybe we want to wait on `bevy_sprite` generally making use of `Aabb2b` so users don't need to construct it manually. But since they **do** need to construct the bounding circle for the ball manually, this doesn't seem like a big deal to me. --------- Co-authored-by: IQuick 143 <[email protected]>
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this issue
Feb 6, 2024
) # Objective Fixes bevyengine#11479 ## Solution - Remove `collide_aabb.rs` - Re-implement the example-specific collision code in the example, taking advantage of the new `IntersectsVolume` trait. ## Changelog - Removed `sprite::collide_aabb::collide` and `sprite::collide_aabb::Collision`. ## Migration Guide `sprite::collide_aabb::collide` and `sprite::collide_aabb::Collision` were removed. ```rust // Before let collision = bevy::sprite::collide_aabb::collide(a_pos, a_size, b_pos, b_size); if collision.is_some() { // ... } // After let collision = Aabb2d::new(a_pos.truncate(), a_size / 2.) .intersects(&Aabb2d::new(b_pos.truncate(), b_size / 2.)); if collision { // ... } ``` If you were making use `collide_aabb::Collision`, see the new `collide_with_side` function in the [`breakout` example](https://bevyengine.org/examples/Games/breakout/). ## Discussion As discussed in the linked issue, maybe we want to wait on `bevy_sprite` generally making use of `Aabb2b` so users don't need to construct it manually. But since they **do** need to construct the bounding circle for the ball manually, this doesn't seem like a big deal to me. --------- Co-authored-by: IQuick 143 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
What problem does this solve or what need does it fill?
After #11439, it seems like it might be possible to nuke the breakout example's custom collision code.
The breakout example makes use of
bevy::sprite::collide_aabb::collidewhich exists in Bevy solely to make this particular example work.The current collision code also assumes that the ball is a rectangle, which is no longer true!
What solution would you like?
Replace the code in
breakoutwith code based on the new bounding volume intersection stuff introduced in #11439 and removebevy::sprite::collide_aabb::collidefrom Bevy.breakoutis relying oncollide_aabb::collidedetermining "which side of the thing was collided with," so this is slightly more involved than it sounds on the surface.What alternative(s) have you considered?
Maybe I've misjudged and it's not time for this yet.
The text was updated successfully, but these errors were encountered: