Skip to content

rename PluginGroupBuilder::add to push #15318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BenjaminBrienen opened this issue Sep 19, 2024 · 1 comment
Closed

rename PluginGroupBuilder::add to push #15318

BenjaminBrienen opened this issue Sep 19, 2024 · 1 comment
Labels
A-App Bevy apps and plugins C-Code-Quality A section of code that is hard to understand or change S-Wontfix This issue is the result of a deliberate design decision, and will not be fixed

Comments

@BenjaminBrienen
Copy link
Contributor

See https://github.com/bevyengine/bevy/pull/15301/files#r1767026192
@BenjaminBrienen BenjaminBrienen added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Sep 19, 2024
@alice-i-cecile
Copy link
Member

Killed in #15305 by @mockersf, who thought this was a bad idea overall. I'm fine to defer to him there.

@alice-i-cecile alice-i-cecile closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
@alice-i-cecile alice-i-cecile added S-Wontfix This issue is the result of a deliberate design decision, and will not be fixed C-Code-Quality A section of code that is hard to understand or change A-App Bevy apps and plugins and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Code-Quality A section of code that is hard to understand or change S-Wontfix This issue is the result of a deliberate design decision, and will not be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alice-i-cecile @BenjaminBrienen