Skip to content

No warning/error on invalid gltf asset label ("#") #9952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
A-Walrus opened this issue Sep 28, 2023 · 4 comments
Closed

No warning/error on invalid gltf asset label ("#") #9952

A-Walrus opened this issue Sep 28, 2023 · 4 comments
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior

Comments

@A-Walrus
Copy link
Contributor

A-Walrus commented Sep 28, 2023 •
edited
Loading

Bevy version

20ed3e0

[Optional] Relevant system information

If you cannot get Bevy to build or run on your machine, please include:

  • 20ed3e0e765405ee334a44ce3c49c72bd29ab753us know!
  • Linux: Fedora 38, Gnome, Wayland

What you did

Modified this line in the example:

bevy/examples/3d/load_gltf.rs

Line 53 in 20ed3e0

scene: asset_server.load("models/FlightHelmet/FlightHelmet.gltf#Scene0"),

replacing Scene0 with random gibberish asdfasdf

What went wrong

Expected to see some error or warning, instead the only thing that happened is no model showed up.
@A-Walrus A-Walrus added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Sep 28, 2023
@A-Walrus A-Walrus reopened this Sep 28, 2023
@alice-i-cecile alice-i-cecile added A-Assets Load files from disk to use for things like images, models, and sounds and removed S-Needs-Triage This issue needs to be labelled labels Sep 28, 2023
@A-Walrus A-Walrus changed the title No warning/error on invalid gltf "# No warning/error on invalid gltf asset label ("#") Sep 28, 2023
@hymm
Copy link
Contributor

hymm commented Oct 3, 2023

does #9751 fix this?

@A-Walrus
Copy link
Contributor Author

A-Walrus commented Oct 3, 2023

does #9751 fix this?

I think so

@ZainlessBrombie
Copy link

image
Got this error when trying on the new branch, so looks good 👍

@A-Walrus
Copy link
Contributor Author

A-Walrus commented Jan 9, 2024

Closed by #11254

@A-Walrus A-Walrus closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hymm @alice-i-cecile @ZainlessBrombie @A-Walrus