Skip to content

Japanese translation #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v0.1.x
Choose a base branch
from

Conversation

hiroshisuga
Copy link

What does this PR do?

Adds a translation of the locale ja.

Closes Issue(s)

Closes #

Motivation

Is it the correct way to add a translation? Hopefully more locales will be added to the branch for v3.0

Copy link

welcome bot commented Mar 16, 2025

Thank you for this contribution! Could you please confirm if you already sent in the signed Contributor License Agreement? See https://docs.bigbluebutton.org/support/faq.html#why-do-i-need-to-sign-a-contributor-license-agreement-to-contribute-source-code Thanks in advance!

@GuiLeme
Copy link
Collaborator

GuiLeme commented Apr 2, 2025

Hello, @hiroshisuga thank you for the contribution, that is correct! But unfortunately we are not currently doing locales yet for this plugin. I will add this feature soon enough, though, and this PR will gladly make a great difference here! Thanks again and I'll keep you up to date.

@antobinary
Copy link
Member

Hi! In the community call yesterday a request for German translation was voiced too. @GuiLeme are we happy enough with the localization (via PRs) for any of the plugins? Perhaps we could mimic here what we do in bigbluebutton/plugin-tour#6

@GuiLeme
Copy link
Collaborator

GuiLeme commented Apr 2, 2025

@antobinary The thing is: we didn't have a pattern to follow before, but now, we are defining it as we can see here: bigbluebutton/plugin-typed-captions#8.

So I think we should try to stick with this pattern quoted above which follows what we do in BBB core. But that's definitely a good discussion

@antobinary
Copy link
Member

Thank you @GuiLeme ! I see #39

@antobinary antobinary changed the base branch from v3.1.x-release to v0.1.x April 17, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants