Feature/v1 #39
Open
Feature/v1 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulrichard
force-pushed
the
feature/v1
branch
3 times, most recently
from
ea66d36 to
443a165
Compare
ulrichard
force-pushed
the
feature/v1
branch
2 times, most recently
from
3c3ebfc to
10c2b54
Compare
tvpeter
reviewed
Feb 10, 2025
| let expected = r#"cHNidP8BAH4BAAAAAmw1RvG4UzfnSafpx62EPTyha6VslP0Er7n3TxjEpeBeAAAAAAD/////2johM0znoXIXT1lg+ySrvGrtq1IGXPJzpfi/emkV9iIAAAAAAP////8BUMMAAAAAAAAZdqkUn3/QltN+0sDj9/DPySS+70/862iIrAAAAAAAAQEKAAAAAAAAAAABUQEHAAABAR9QwwAAAAAAABYAFOzlJlcQU9qGRUyeBmd56vnRUC5qIgYDKwVYB4vsOGlKhJM9ZZMD4lddrn6RaFkRRUEVv9ZEh+ME7OUmVwAA"#; | ||
| let expected = r#"cHNidP8BAH4BAAAAAmw1RvG4UzfnSafpx62EPTyha6VslP0Er7n3TxjEpeBeAAAAAAD/////MQvsP2eDTCk3vWfQJ50IOFWLwuTHPsnYikR1hosdK0sAAAAAAP3///8BUMMAAAAAAAAZdqkUn3/QltN+0sDj9/DPySS+70/862iIrAAAAAAAAQEKAAAAAAAAAAABUQEHAAABAR9QwwAAAAAAABYAFOzlJlcQU9qGRUyeBmd56vnRUC5qIgYDKwVYB4vsOGlKhJM9ZZMD4lddrn6RaFkRRUEVv9ZEh+ME7OUmVwAA"#; | ||
|
|
||
| assert_eq!(psbt_b64, expected); |
There was a problem hiding this comment.
This is failing because the Psbt produced is version 2 while the expected Psbt value you supplied is version 1. This is coming from here. Every other data is the same.
|
You should start with Otherwise ACK |
ulrichard
force-pushed
the
feature/v1
branch
6 times, most recently
from
7c55933 to
e4b104d
Compare
|
tACK e4b104d |
tvpeter
approved these changes
Apr 26, 2025
|
Looks like you need to take the WASM CI job out for this PR too or you can rebase it after merging #38 is merged. |
|
@notmandatory I rebased on master after merging the other branch. So, everything should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adapted the signature counts in the tests to make the tests pass.
In the old version there was a flag remove_partial_sigs in SignOptions.
I removed the test tampered_proof_sighash_tx because the expected error was not thrown, and apparently doesn't exist any more.