Skip to content

test: Move bump fee + foreign utxo tests #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ValuedMammal
Copy link
Collaborator

@ValuedMammal ValuedMammal commented Apr 8, 2025

These files are added to wallet/tests directory

  • add_foreign_utxo.rs
  • build_fee_bump.rs
  • common.rs

fixes #21
fixes #238

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

These files added to wallet/tests directory
- add_foreign_utxo.rs
- build_fee_bump.rs
- common.rs
@ValuedMammal ValuedMammal self-assigned this Apr 8, 2025
@ValuedMammal ValuedMammal added this to the 1.3.0 milestone Apr 8, 2025
@ValuedMammal ValuedMammal moved this to Needs Review in BDK Wallet Apr 8, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14324315948

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.525%

Totals Coverage Status
Change from base Build 14270666930: 0.0%
Covered Lines: 7269
Relevant Lines: 8401

💛 - Coveralls

@ValuedMammal ValuedMammal moved this from Needs Review to In Progress in BDK Wallet May 12, 2025
@ValuedMammal ValuedMammal removed this from the Wallet 2.0.0 milestone May 25, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you consider separating the taproot-related test cases into a different module? There are many test cases associated with taproot.

Copy link
Contributor

@tvpeter tvpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 22e28b2

Thank you for working on this Mammal.

I did not proceed with #238 since they are related.

There are some warnings related to bitcoin::key::TweakedKeypair::to_inner but once you rebase, they should be gone.

I have left a comment on whether it is a good idea to separate taproot-related test cases into their module.

Thank you

@ValuedMammal ValuedMammal added the tests New or improved tests label Jun 19, 2025
@ValuedMammal ValuedMammal added this to the Wallet 2.1.0 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests New or improved tests
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Split tests into multiple files Move bump-fee and foreign utxo tests to their own files
3 participants