fix: make sure tx_build does not change the order of add_utxos when u…

[eauxxs]

fixes #244

[nymius]

Thanks for working on this! I'd prefer to not add the indexmap dependency just to cover this case. I've proposed an alternative solution in #261

[eauxxs]

@nymius Indeed. Adding a dependency for a small case is not a good idea. How about this idea? I still think it is better to replace the code in place as much as possible, rather than invading the code to do index calculations.

[nymius]

Thanks for this! I still think is a workaround for the dependency issue. You are moving the problem of maintaining compatibility with the dependency to maintaining the OrderUtxos structure ourselves. Is a solution, but I still think we can do better.

[coveralls]

Pull Request Test Coverage Report for Build 15555027734

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 39 of 39 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.06%) to 85.61%

---

Totals
Change from base Build 15476130196:	0.06%
Covered Lines:	7413
Relevant Lines:	8659

---

💛 - Coveralls