Trafficgraphwidget knots #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just saw your comments in the PR for core. Happy to split into smaller PRs although for knots, there are fewer changes given much of the functionality is already present. |
rebroad
force-pushed
the
trafficgraphwidget-knots
branch
from
6232958 to
e50f6f7
Compare
rebroad
force-pushed
the
trafficgraphwidget-knots
branch
from
e50f6f7 to
6807d66
Compare
…persistence
This commit significantly improves the network traffic graph widget with:
1. Multiple timeframe support - View traffic data across different time
periods (5 minutes to 28 days) using an enhanced slider interface
2. Traffic data persistence - Save and restore traffic information
between sessions, preserving historical traffic patterns
3. Interactive visualization features:
- Logarithmic scale toggle (mouse click) for better visualization of
varying traffic volumes
- Interactive tooltips showing detailed traffic information at specific points
- Yellow highlight indicators for selected data points
4. Smooth transitions between different time ranges with animated scaling
These improvements allow users to better monitor and analyze network
traffic patterns over time, which is especially useful for debugging
connectivity issues or understanding network behavior under different
conditions.
The implementation includes proper thread-safety considerations and
handles edge cases like time jumps or missing data appropriately.
rebroad
force-pushed
the
trafficgraphwidget-knots
branch
from
6807d66 to
592a78b
Compare
|
Were you going to split it into multiple commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the network traffic graph widget in the Debug window to provide:
Motivation
The existing network traffic graph has limited utility with its fixed time range and lack of historical data preservation. This enhancement allows users to:
These improvements are valuable for:
Implementation
The implementation preserves all existing functionality while adding new features:
Supporting changes:
Testing
Tested on Linux with various network conditions. The new functionality can be exercised by:
Documentation
The changes are mostly self-documenting through the UI and are constrained to the Qt interface without affecting core functionality.
Compatibility
This PR maintains compatibility with existing functionality. The data persistence file uses proper serialization versioning to allow for future format changes if needed.