Skip to content

fix: Improve CUDA version detection and error handling #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 42 additions & 13 deletions bitsandbytes/cuda_specs.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,26 +21,55 @@ def get_compute_capabilities() -> list[tuple[int, int]]:


@lru_cache(None)
def get_cuda_version_tuple() -> tuple[int, int]:
if torch.version.cuda:
return tuple(map(int, torch.version.cuda.split(".")[0:2]))
elif torch.version.hip:
return tuple(map(int, torch.version.hip.split(".")[0:2]))
def get_cuda_version_tuple() -> Optional[tuple[int, int]]:
"""Get CUDA/HIP version as a tuple of (major, minor)."""
try:
if torch.version.cuda:
version_str = torch.version.cuda
elif torch.version.hip:
version_str = torch.version.hip
else:
return None

return None
parts = version_str.split(".")
if len(parts) >= 2:
return tuple(map(int, parts[:2]))
return None
except (AttributeError, ValueError, IndexError):
return None


def get_cuda_version_string() -> str:
major, minor = get_cuda_version_tuple()
def get_cuda_version_string() -> Optional[str]:
"""Get CUDA/HIP version as a string."""
version_tuple = get_cuda_version_tuple()
if version_tuple is None:
return None
major, minor = version_tuple
return f"{major * 10 + minor}"


def get_cuda_specs() -> Optional[CUDASpecs]:
"""Get CUDA/HIP specifications."""
if not torch.cuda.is_available():
return None

return CUDASpecs(
highest_compute_capability=(get_compute_capabilities()[-1]),
cuda_version_string=(get_cuda_version_string()),
cuda_version_tuple=get_cuda_version_tuple(),
)
try:
compute_capabilities = get_compute_capabilities()
if not compute_capabilities:
return None

version_tuple = get_cuda_version_tuple()
if version_tuple is None:
return None

version_string = get_cuda_version_string()
if version_string is None:
return None

return CUDASpecs(
highest_compute_capability=compute_capabilities[-1],
cuda_version_string=version_string,
cuda_version_tuple=version_tuple,
)
except Exception:
return None