[PM-18955] Improve performance of Billing invocations on Collections page

[jonashendrickx]

…ions

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18955

📔 Objective

There were two options to solve checking whether a payment method already exists for a trial subscription:

• Whether country and postal code are entered for a customer, both of which are required for sales tax compliance. Already exposed by the metadata endpoint. However, it's not a guarantee that the payment method still exists once the billing information has been entered

• customer.invoice_settings has a property with the default payment id. We would have to return it with the metadata endpoint. Is more thorough than bullet point i18n #1.

📸 Screenshots

Screen.Recording.2025-04-07.at.16.41.13.mov

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 37.07%. Comparing base (ad2e3a4) to head (4cc8421).
Report is 17 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...nsole/organizations/collections/vault.component.ts	0.00%	7 Missing ⚠️
...web/src/app/billing/services/trial-flow.service.ts	0.00%	1 Missing ⚠️
...src/app/billing/shared/payment-method.component.ts	0.00%	1 Missing ⚠️
...app/secrets-manager/overview/overview.component.ts	0.00%	1 Missing ⚠️
...response/organization-billing-metadata.response.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14159      +/-   ##
==========================================
+ Coverage   37.05%   37.07%   +0.02%     
==========================================
  Files        3194     3203       +9     
  Lines       92352    92531     +179     
  Branches    16571    16593      +22     
==========================================
+ Hits        34217    34308      +91     
- Misses      55592    55677      +85     
- Partials     2543     2546       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – 03d8cee1-5a43-4e86-8880-12ae8eb4f348

Great job, no security vulnerabilities found in this Pull Request

[JimmyVo16]

Looks good from AC

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cd-bitwarden]

Nice work, approved ✅