PM-16517: Create personal use plan for additional storage #5205
Conversation
| @@ -38,7 +38,7 @@ public Families2019PasswordManagerFeatures() | |||
| HasPremiumAccessOption = true; | |||
|
|
|||
| StripePlanId = "personal-org-annually"; | |||
| StripeStoragePlanId = "storage-gb-annually"; | |||
There was a problem hiding this comment.
Are you changing the existing storage name , what of the users that has subscribed to it. I am not sure you are able to change a product name when it has subscribers in stripe
There was a problem hiding this comment.
@cyprain-okeke We will execute a migration script separately. So there's no need to migrate to an entire new plan.
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5205 +/- ##
=======================================
Coverage 45.80% 45.80%
=======================================
Files 1609 1609
Lines 73170 73170
Branches 6556 6556
=======================================
Hits 33516 33516
Misses 38226 38226
Partials 1428 1428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…rate-product-personal-use' into PM-16517-Additional-storage-separate-product-personal-use
…rate-product-personal-use' into PM-16517-Additional-storage-separate-product-personal-use
|
…-personal-use # Conflicts: # src/Core/Services/Implementations/StripePaymentService.cs
|
Fixed merge conflict @bitwarden/team-billing-dev |
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16517
📔 Objective
Separate price & product for personal use Password Manager plans when additional storage is purchased.
To validate still internally whether we update existing subscriptions when listening to webhooks or we update them all at once in bulk.
📸 Screenshots
After the migration script has been executed separately, we will issue the correct invoice during the next cycle.
Screen.Recording.2025-01-29.at.13.16.15.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes