Skip to content

[PM-12493] Extract ConfirmUser methods from OrganizationService into commands #5505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 24, 2025

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Mar 14, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12493

📔 Objective

This PR extracts the organization user confirmation functionality from the OrganizationService into a dedicated ConfirmOrganizationUserCommand class following the CQRS pattern.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Mar 14, 2025

Logo
Checkmarx One – Scan Summary & Detailsd757413e-26a1-4938-ac28-46c2ca87188b

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/AdminConsole/OrganizationUserRevokedForSingleOrgPolicy.html.hbs: 5
detailsA Content Security Policy is not explicitly defined within the web-application.
Attack Vector

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 92.06349% with 10 lines in your changes missing coverage. Please review.

Project coverage is 44.55%. Comparing base (d345937) to head (e95164f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rganizationUsers/ConfirmOrganizationUserCommand.cs 94.11% 4 Missing and 3 partials ⚠️
...Console/Controllers/OrganizationUsersController.cs 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5505      +/-   ##
==========================================
+ Coverage   44.54%   44.55%   +0.01%     
==========================================
  Files        1543     1544       +1     
  Lines       70761    70793      +32     
  Branches     6333     6333              
==========================================
+ Hits        31519    31545      +26     
- Misses      37889    37895       +6     
  Partials     1353     1353              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@r-tome r-tome marked this pull request as ready for review March 21, 2025 11:29
@r-tome r-tome requested a review from a team as a code owner March 21, 2025 11:29
@r-tome r-tome requested a review from jrmccannon March 21, 2025 11:29
@r-tome r-tome removed the needs-qa label Mar 24, 2025
@r-tome r-tome added needs-qa and removed needs-qa labels Mar 24, 2025
@r-tome r-tome merged commit 24b63f2 into main Mar 24, 2025
53 of 55 checks passed
@r-tome r-tome deleted the ac/pm-12493/create-organizationuser-confirm-command branch March 24, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants