-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-12493] Extract ConfirmUser methods from OrganizationService into commands #5505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-12493] Extract ConfirmUser methods from OrganizationService into commands #5505
Conversation
…d interface for managing organization user confirmations
…nfirmation scenarios
…serCommand for user confirmation processes
…ionService and OrganizationService
…y and consistency
New Issues (1)Checkmarx found the following issues in this Pull Request
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5505 +/- ##
==========================================
+ Coverage 44.54% 44.55% +0.01%
==========================================
Files 1543 1544 +1
Lines 70761 70793 +32
Branches 6333 6333
==========================================
+ Hits 31519 31545 +26
- Misses 37889 37895 +6
Partials 1353 1353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12493
📔 Objective
This PR extracts the organization user confirmation functionality from the
OrganizationService
into a dedicatedConfirmOrganizationUserCommand
class following the CQRS pattern.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes