-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-17615] Refactor OrganizationService to remove feature flag check for PushSyncOrgKeysOnRevokeRestore #5547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cOrgKeysOnRevokeRestore
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5547 +/- ##
=======================================
Coverage 45.12% 45.12%
=======================================
Files 1565 1565
Lines 71723 71719 -4
Branches 6424 6424
=======================================
Hits 32363 32363
+ Misses 37982 37979 -3
+ Partials 1378 1377 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # src/Core/AdminConsole/Services/Implementations/OrganizationService.cs # test/Core.Test/AdminConsole/Services/OrganizationServiceTests.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment below but it's approved once you've done that. Please feel free to get an approval from anyone else on the team if you want to get it in to rc.
...sole/OrganizationFeatures/OrganizationUsers/RestoreUser/v1/RestoreOrganizationUserCommand.cs
Show resolved
Hide resolved
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17615
📔 Objective
This is part of feature flag removal work.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes