Skip to content

[PM-17615] Refactor OrganizationService to remove feature flag check for PushSyncOrgKeysOnRevokeRestore #5547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 4, 2025

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Mar 24, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17615

📔 Objective

This is part of feature flag removal work.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsec54e87f-f8d1-40e7-913c-c9537565b15f

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.12%. Comparing base (67d7d68) to head (e7d2e45).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...le/Services/Implementations/OrganizationService.cs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5547   +/-   ##
=======================================
  Coverage   45.12%   45.12%           
=======================================
  Files        1565     1565           
  Lines       71723    71719    -4     
  Branches     6424     6424           
=======================================
  Hits        32363    32363           
+ Misses      37982    37979    -3     
+ Partials     1378     1377    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@r-tome r-tome marked this pull request as ready for review March 24, 2025 14:25
@r-tome r-tome requested a review from a team as a code owner March 24, 2025 14:25
@r-tome r-tome requested a review from eliykat March 24, 2025 14:25
eliykat
eliykat previously approved these changes Mar 25, 2025
# Conflicts:
#	src/Core/AdminConsole/Services/Implementations/OrganizationService.cs
#	test/Core.Test/AdminConsole/Services/OrganizationServiceTests.cs
@r-tome r-tome removed the needs-qa label Apr 2, 2025
@r-tome r-tome requested a review from eliykat April 2, 2025 10:48
eliykat
eliykat previously requested changes Apr 4, 2025
Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment below but it's approved once you've done that. Please feel free to get an approval from anyone else on the team if you want to get it in to rc.

Copy link

sonarqubecloud bot commented Apr 4, 2025

@r-tome r-tome dismissed eliykat’s stale review April 4, 2025 13:52

Requested change was made

@r-tome r-tome merged commit e176e6e into main Apr 4, 2025
54 checks passed
@r-tome r-tome deleted the ac/pm-17615/remove-flagged-logic branch April 4, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants