Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-19009] Remove feature flag 'pm-15179-add-existing-orgs-from-provi… #5579

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Mar 31, 2025

…der-portal'

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19009

📔 Objective


The dropdown options are

New organization

Existing organization

Selecting “New organization” triggers the existing workflow

Selecting “Existing organization” triggers a new workflow (see figma design)

Both the Provider Admin and Service User has permissions to select both buttons. If the assigned seats exceed the available seats for an organizations, a Service User will not be able to select that organization.
Add an “Add existing organization” option to the Provider Portal. Given a user is a member of a Provider Portal AND an Owner of an organization, then the user can add that organization to the Provider Portal.

The transition from a non-managed organization to a managed organization will require a billing migration. We should leverage the consolidated billing migration for this. The following qualifies as an existing organization that can be migrated:

has an active subscription

the active provider user (any role) is an Owner of the organization

a service user can only add organizations that is within the provider’s seat minimum. The organization will be in a disabled state if the organization seats exceed the provider’s available seats.

📸 Screenshots

Screen.Recording.2025-04-08.at.21.37.36.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

LaunchDarkly flag references

❌ 1 flag removed

Name Key Aliases found Info
Add existing orgs from Provider Portal pm-15179-add-existing-orgs-from-provider-portal ✅ all references removed

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details04497027-0229-4a31-8c57-c817baf6797e

Fixed Issues (4)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 164
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 86
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 96

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.91%. Comparing base (ad05e3f) to head (f6795d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5579   +/-   ##
=======================================
  Coverage   44.90%   44.91%           
=======================================
  Files        1558     1558           
  Lines       70994    70991    -3     
  Branches     6339     6338    -1     
=======================================
  Hits        31883    31883           
+ Misses      37762    37759    -3     
  Partials     1349     1349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants