Skip to content

[PM-17823]Add feature toggle for admin sponsored families to admin portal #5595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: PM-17830
Choose a base branch
from

Conversation

cyprain-okeke
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17823

📔 Objective

Acceptance criteria

GIVEN: the user is viewing an organization in the Bitwarden Portal

THEN: there is a feature toggle for admin sponsored families

📸 Screenshots

Uploading Screen Recording 2025-04-02 at 18.46.30.mov…

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke requested review from a team as code owners April 2, 2025 17:47
@cyprain-okeke cyprain-okeke requested a review from jrmccannon April 2, 2025 17:47
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Logo
Checkmarx One – Scan Summary & Details8f940669-cdd7-4593-a71e-8be3a65bb15f

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 77
detailsMethod RegenerateKeysAsync at line 77 of /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs gets a parameter from a user request...
Attack Vector
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 77
detailsMethod Post at line 77 of /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs gets a parameter from a user request from Post. This param...
Attack Vector
Fixed Issues (3)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Billing/Controllers/PayPalController.cs: 70
MEDIUM CSRF /src/Api/NotificationCenter/Controllers/NotificationsController.cs: 67
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/AdminConsole/OrganizationUserRevokedForSingleOrgPolicy.html.hbs: 5

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.87%. Comparing base (6fbc823) to head (2a5aba6).

Files with missing lines Patch % Lines
...AdminConsole/Views/Shared/_OrganizationForm.cshtml 0.00% 3 Missing ⚠️
...dminConsole/Controllers/OrganizationsController.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           PM-17830    #5595      +/-   ##
============================================
- Coverage     47.87%   47.87%   -0.01%     
============================================
  Files          1558     1558              
  Lines         71049    71053       +4     
  Branches       6344     6347       +3     
============================================
  Hits          34018    34018              
- Misses        35630    35634       +4     
  Partials       1401     1401              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jrmccannon
jrmccannon previously approved these changes Apr 3, 2025
@cyprain-okeke cyprain-okeke removed the request for review from a team April 3, 2025 14:34
@cyprain-okeke cyprain-okeke changed the base branch from PM-17830 to main April 15, 2025 15:43
@cyprain-okeke cyprain-okeke dismissed jrmccannon’s stale review April 15, 2025 15:43

The base branch was changed.

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner April 15, 2025 15:43
@cyprain-okeke cyprain-okeke changed the base branch from main to PM-17830 April 15, 2025 15:44
@cyprain-okeke cyprain-okeke removed the request for review from a team April 15, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants