Skip to content

Include Root Certificates in Custom Trust Store #5624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

justindbaur
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19599
https://bitwarden.atlassian.net/browse/PM-19601

📔 Objective

I realized in #5609 that if you include a "additional" certificates directory that directory is treated as the ONLY certificates that are valid for remote servers, kinda defeating the name. To fix that we just include the system root CA's in our custom trust store.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@justindbaur justindbaur requested a review from a team as a code owner April 8, 2025 16:16
@justindbaur justindbaur requested a review from dani-garcia April 8, 2025 16:16
Copy link

sonarqubecloud bot commented Apr 8, 2025

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.72%. Comparing base (a8403f3) to head (80a6afd).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5624      +/-   ##
==========================================
- Coverage   45.73%   45.72%   -0.01%     
==========================================
  Files        1600     1600              
  Lines       72613    72606       -7     
  Branches     6504     6504              
==========================================
- Hits        33206    33198       -8     
  Misses      37990    37990              
- Partials     1417     1418       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Apr 8, 2025

Logo
Checkmarx One – Scan Summary & Details295415cd-fce7-4ab6-893c-2baede6a8584

Great job, no security vulnerabilities found in this Pull Request

@justindbaur justindbaur merged commit f29b5c5 into main Apr 8, 2025
54 checks passed
@justindbaur justindbaur deleted the also-trust-root-certificates branch April 8, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants