-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-20142] Split GlobalSettings in file in the same namespace #5641
base: main
Are you sure you want to change the base?
[PM-20142] Split GlobalSettings in file in the same namespace #5641
Conversation
…ServiceUriSettings.cs
…nnectionStringSettings.cs
…ProtectionSettings.cs
…stributedCacheSettings.cs
…o file DistributedIpRateLimitingSettings.cs
…DomainVerificationSettings.cs
…oggingSettings.cs
…tityServerSettings.cs
…file ImportCiphersLimitationSettings.cs
…ile InfrastructureResourceProvider.cs
…cationHubPoolSettings, NotificationHubSettings and NotificationsSettings classes from GlobalSettings.cs to files in the same namespace
…Settings, SsoSettings, StripeSettings, SyslogSettings, WebPushSettings and YubicoSettings classes from GlobalSettings.cs to file in the same namespace
…external, internal uri and building directories.
Thank you for your contribution! We've added this to our internal Community PR board for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
@S-Kakar thank you for reply. However I don't have access to you Jira board because I'm contributor from the community. |
📔 Objective
Restructure the monolithic
GlobalSettings.cs
file into separate class-specific files, adhering to the Single Responsibility Principle (SRP) and Separation of Concerns (SoC), to achieve the following goals:📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes